Community vote : merge without review

petitminion

Dear community,

I'm having issues to get reviews on my mr's and we have delays regarding Nlnet funds : we need to merge all the feature before the end of the year, that is relatively short. While we probably all agree it would be ideal to have reviews before merging anything to the codebase, we don't have this possibility.

So Funkwhale is actually left with two options :

Let me merge to the main branch without reviews
Drop some of the feature I'm working on.

I want to recall that if there people here willing to do some reviews (considering it can be paid) please reach out 🙂

I've been working on funkwhale since various years now, my first mr was 3 years ago. The list is here. But I'm not a professional developer and I didn't do dev studies, I learned getting reviews from @gcrk. I think I'm able to develop funkwhale keeping it's current structure and following good practices. But errors can always append so I'm opening this community vote to know the community opinion.

The list of features : https://dev.funkwhale.audio/funkwhale/funkwhale/-/boards/671?label_name[]=Prio%3A%3AFunding&assignee_username=petitminion

Have a good day people and see you around 😃

FUji

with the recent issue brought to light by the XZ Utils backdoor, I hope we can agree that accepting changes without review is a very very bad idea.

petitminion

FUji To be clear : this is not about accepting everybody changes without review, it's only to accept change from myself since I'm the one assigned to the the Nlnet tasks. We could extent this to all members of the development group but I can do reviews so I don't know if it's useful.

Also from it's beginnings, Funkwhale was develop without reviews or only with Agathe reviews. This changed when the current team took over her work.

gcrk

petitminion it’s only to accept change from myself since I’m the one assigned to the the Nlnet tasks

This really doesn't matter. If your account is compromised, Funkwhale would be. The approval is the protection for this scenario and removing it would be a serious security issue.

petitminion

Last call for this vote 🙂 According to our status this vote will be extended by two weeks considering only three persons voted.

EDIT : I cannot extend the pool time so if someone want to vote in the next two week let me know I will open a new poll

petitminion

if my account is compromise this vote wont matter anyway since I can already change this setting and make merge request without review if I want.

petitminion

so I will allow myself to merged without review. Will use this carefully. If anybody want to work on the codebase let me know !