What's wrong with libraries, and a path to fix them

gcrk

It is slightly related to the collections from my point of view (which is why I asked @fleshgolem to add a comment here): Right now you have to select a library on import time. This is also why its only available via CLI, because the user might or might not be aware of the server directory structure (and exposing it using Funkwhale is something we would need to think really deep before implementing it, because it might be a security issue). Wrong, see https://forum.funkwhale.audio/d/214-whats-wrong-with-libraries-and-a-path-to-fix-them/58

With the collections, we kind of change this: The first step is always to import or upload music, and organizing it into collections is a later step. This way we can allow users to import music from a specific directory (where the admin might mount whatever into) or the admin can import music which is available to all users (the only issue to consider here is copyright).

petitminion if we adress this this could be a solution to : https://dev.funkwhale.audio/funkwhale/funkwhale/-/issues/2120#note_50233

This is about optimizing the in-place import, which is something we can do independently from changing the way how imports work in general

phw

I like the idea of separating the libraries from collections. I think it would fit my use case pretty well. Let me explain what setup I currently have:
I have all my music collection in a single folder on my funkwhale server. That music consists of non-freely licensed music I need to keep private to myself and CC licensed music I would like to share.
Currently I import the music into FW using the librarie's upload UI and browsing to newly added music with the folder selection and importing this. In order to separate the CC licensed music I need two libraries. I then need to be careful to always import the correct album folder into the correct library, as a single imported album can only be part of one album (due to #1277). Hence I can't select the entire folder and import all. If I accidentally import into the wrong library it messes things up.

If there was a separation between libraries and collections it would simplify things and I just could import the entire music folder into one library, then have two separate collections for the private and CC licensed music.

gcrk This is also why its only available via CLI, because the user might or might not be aware of the server directory structure

I always assumed that importing music into a library via Library > Uploading > Import music from your server and using the folder selection there would be the same as the in-place import. Or is this something entirely different again?

petitminion

gcrk as @phw said we already can browse the fw data directory to upload tracks into a library (could be the same process for collections). What we don't have is a working --watch option @fleshgolem was speaking about. And this is not dependent of collection, its more about the in-place import. But maybe there is something I don't understand ?

gcrk

phw I like the idea of separating the libraries from collections. I think it would fit my use case pretty well. Let me explain what setup I currently have:

Probably nitpicking, but just to get things straight: Collections will replace libraries. There is no reason to have them both, collections are way more powerful and flexible. The major difference from my point of view is that you will have a pool of music belonging to a user (so basically a single library, if you want) and on top of this there are collections which allows a user to do flexible allocations of the content. Imagine those collections as a window into a house full of music, but you can flexibly configure what users can see through this window. Additionally you can decide which user is allowed to look though what window. Hope this makes sense (See the spec for more detailed explanation)

gcrk

petitminion Wait, we do? Where, how? I am surprised, sorry for talking nonsense then!

gcrk

petitminion And this is not dependent of collection, its more about the in-place import. But maybe there is something I don't understand ?

https://forum.funkwhale.audio/d/214-whats-wrong-with-libraries-and-a-path-to-fix-them/55

petitminion

[upl-image-preview url=https://forum.funkwhale.audio/assets/files/2023-05-04/1683206725-517600-image.png]

gcrk

petitminion I cannot browser there, tho. I can not even type a path there.

phw

gcrk That view became a bit bugged with some recent changes. I haven't reported it yet. But previously when you clicked on a folder it opened fast. Now you have to wait a bit until it shows the folder's contents. If you click on another folder again before it finished loading the first folder the entire loading gets confused and doesn't load at all. I'll open an issue about that.

gcrk

phw Thanks! As noted before, I am a bit concerned about the security here. How far can you climb the tree up? Its probably not a good idea to expose files to everyone having an account on a funkwhale server.

petitminion

I don't really have an opinion on this but I would like to keep the feature, and add a permission for it if you think its needed.

As for it's fit in the collection, I think this is more about upload than collection. Because when you upload song they will endup in your general library no matter how you upload them. And then you will put them in your collections. But if you want to add this in the collection spec I don't really care ^^ I just think it would better fit in https://forum.funkwhale.audio/d/296-new-upload-process-draft-spec or even better in a new spec.

gcrk

petitminion Thank you, I already forgot about this one.

« Previous Page