Failed to follow remote library in an allow-list setup

dgageot

Hello,

To begin with, I would like to thank the contributors of Funkwhale! It's a wonderful servce, I'm using it everyday to stream my library everywhere.

Recently, a friend of mine decided to deploy her Funkwhale instance (1.2.5, containerless) on her server.
We were willing to federate our instances, so I have added her pod address to my allow-list, same thing on her side.
The problem is that our library following requests are endlessly in approval pending state. We were able to send a follow request to our respective libraries, but even once accepted on each side, the state of the request does not change. The only way to access remote libraries content was to expose libraries publicly. Since it could be a great backdoor to access our libraries without authentification, I wish we could find a solution to repair the library following mecanism on our setup.

Interesting information: logs from celery worker show a 400 Bad Request response from the remote instance when performing a deliver_to_remote_inbox task:
[2022-07-08 11:43:59,952: ERROR/ForkPoolWorker-4] Task federation.deliver_to_remote_inbox[[obfuscated]] raised unexpected: HTTPError('400 Client Error: Bad Request for url: https://[obfuscated]/federation/shared/inbox')

My setup is a Funkwhale 1.2.5 deployed in containers using the multi-container solution.

Does anyone have an insight on what could be wrong in our setup?
I'm willing to transfer this to issue tracker but I wasn't sure to provide a rigourous reproduction procedure.

Have a great day,
Dylan

gcrk

dgageot Hi Dylan and thank you for the kind words! 🙂

dgageot The only way to access remote libraries content was to expose libraries publicly.

this means the only thing you need to change is set the visibility of the library itself to public to make it work? This would already eliminate a lot of the possible pitfalls, but its for sure no solution.

To be totally fair I would bet its a bug in Funkwhale, not in your setup. I would need to read some code to get a hint what might be the cause. Maybe @petitminion knows a little better?

petitminion

Hello !
I'm not shure, I should look at it maybe we could open an issue ? If the library is set to "only from this instance" or "private" it could make sens there is a bad request on approval. But the library shouldn't be visible either so anyway there is a bug somewhere.

gcrk

petitminion I am not sure, my libraries are private but I want to share them by URL with some friends, so I'd expect its possible to follow them, but only with approval.